3 Commits

Author	SHA1	Message	Date
Knacky	11ce3cfb86	fix(frontend): code-review polish — replaceState, arrow-key nav, TabId, comment ... Fix 4: useHashTab navigate() uses history.replaceState instead of window.location.hash assignment — no spurious history entries, no anchor-jump scroll side-effect. Fix 5: Tabs ArrowLeft/ArrowRight keyboard nav (WAI-ARIA tabs pattern). Fix 6: TabId union type in EngagementDetailPage, cast from string for type-safe switch on activeTab without breaking Tabs.onChange signature. Fix 7: intentional comment on UsersAdminPage reset-password aerated row. Tests: 236/236 (+2 arrow-key assertions in Tabs.test.tsx). Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>	2026-06-21 22:20:51 +02:00
Knacky	790ced4204	fix(frontend): design-review polish — table-compact height, header type-scale, tabs a11y ... Fix 1 (A): move row height constraint from min-height on tbody tr (CSS no-op on table-row) to height: 32px on td (works on table-cell). Fix 2 (A): table header text-[11px] -> text-[12px] to align with documented caption scale. Fix 3: add aria-controls + id to Tabs buttons; wrap active tab content in role="tabpanel" + aria-labelledby in EngagementDetailPage. Test: add aria-controls/id assertion to Tabs.test.tsx (234 total). Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>	2026-06-21 22:18:09 +02:00
Knacky	bca39dcca7	feat(frontend): add Tabs primitive + useHashTab hook ... - useHashTab: pure-TS hook reading window.location.hash, falls back to defaultId, hashchange listener cleaned up on unmount - Tabs: <Tabs items activeId onChange> with tab-underline / tab-underline-active recipes and count-pill (rounded-pill exception per DESIGN.md) - index.css: tab-underline*, tab-count-pill*, alert-*, table-compact recipes Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>	2026-06-21 22:10:59 +02:00